gitMirror/spdlog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add unit test for daily_filename_format_calculator

Browse Source
This commit is contained in:
Charless Milette 2021-11-15 15:46:22 -05:00
parent a6945d046f
commit ba120e524b
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/spdlog/sinks/daily_file_sink.h
View File

@ -75,7 +75,7 @@ struct daily_filename_format_calculator
return buf; return buf;
#else #else
fmt::basic_memory_buffer<filename_t::value_type> tm_format; fmt::basic_memory_buffer<filename_t::value_type> tm_format;
tm_format.append(specs.begin(), specs.end()); tm_format.append(filename.c_str(), filename.c_str() + filename.size());
// By appending an extra space we can distinguish an empty result that // By appending an extra space we can distinguish an empty result that
// indicates insufficient buffer size from a guaranteed non-empty result // indicates insufficient buffer size from a guaranteed non-empty result
// https://github.com/fmtlib/fmt/issues/2238 // https://github.com/fmtlib/fmt/issues/2238

10
tests/test_daily_logger.cpp
View File

@ -142,6 +142,16 @@ TEST_CASE("daily_file_sink::daily_filename_calculator", "[daily_file_sink]]")
} }
#endif #endif
TEST_CASE("daily_file_sink::daily_filename_format_calculator", "[daily_file_sink]]")
{
std::tm tm = spdlog::details::os::localtime();
// example-YYYY-MM-DD.log
auto filename =
spdlog::sinks::daily_filename_format_calculator::calc_filename(SPDLOG_FILENAME_T("example-%Y-%m-%d.log"), tm);
REQUIRE(filename == spdlog::fmt_lib::format(SPDLOG_FILENAME_T("example-{:04d}-{:02d}-{:02d}.log"), tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday));
}
/* Test removal of old files */ /* Test removal of old files */
static spdlog::details::log_msg create_msg(std::chrono::seconds offset) static spdlog::details::log_msg create_msg(std::chrono::seconds offset)
{ {