From 8afe18f148aa16fa5bd27ba9355bb7d4252f8667 Mon Sep 17 00:00:00 2001 From: gabime Date: Mon, 10 Jun 2019 20:10:28 +0300 Subject: [PATCH] Minor improvement CMakeLists to use generators --- cmake/utils.cmake | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/cmake/utils.cmake b/cmake/utils.cmake index e5870fd5..2ef3cbe7 100644 --- a/cmake/utils.cmake +++ b/cmake/utils.cmake @@ -25,12 +25,10 @@ endfunction() # Turn on warnings on the given target function(spdlog_enable_warnings target_name) - if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang") - target_compile_options(${target_name} PRIVATE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors) - endif() - if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC") - target_compile_options(${target_name} PRIVATE /W4 /WX ) - endif() + target_compile_options(${target_name} PRIVATE + $<$,$,$>: + -Wall -Wextra -Wconversion -pedantic -Wfatal-errors> + $<$:/W4 /WX>) endfunction()