gitMirror/spdlog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove switch statement from wincolor_sink::set_color_mode_impl

Browse Source
This commit is contained in:
Gabi Melman 2021-02-13 23:53:36 +02:00
parent 91046e6ca4
commit 0ade18828d
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
include/spdlog/sinks/wincolor_sink-inl.h
View File

@ -60,7 +60,7 @@ void SPDLOG_INLINE wincolor_sink<ConsoleMutex>::log(const details::log_msg &msg)
msg.color_range_start = 0;
msg.color_range_end = 0;
memory_buf_t formatted;
formatter_->format(msg, formatted);
formatter_->format(msg, formatted);
if (should_do_colors_ && msg.color_range_end > msg.color_range_start)
{
// before color range
@ -108,20 +108,16 @@ void SPDLOG_INLINE wincolor_sink<ConsoleMutex>::set_color_mode(color_mode mode)
template<typename ConsoleMutex>
void SPDLOG_INLINE wincolor_sink<ConsoleMutex>::set_color_mode_impl(color_mode mode)
{
switch (mode)
if (mode == color_mode::automatic)
{
case color_mode::always:
should_do_colors_ = true;
break;
case color_mode::never:
should_do_colors_ = false;
break;
default:
// should do colors only if out_handle_ points to actual console.
// should do colors only if out_handle_ points to actual console.
DWORD console_mode;
bool in_console = ::GetConsoleMode(static_cast<HANDLE>(out_handle_), &console_mode) != 0;
should_do_colors_ = in_console;
break;
}
else
{
should_do_colors_ = mode == color_mode::always ? true : false;
}
}