Commit Graph

1461 Commits

Author SHA1 Message Date
Copybara-Service
b53547bf01 Merge pull request #3797 from glandium:issue3514
PiperOrigin-RevId: 444444700
Change-Id: I8ac5cc96cc6eb9d583fa7e3fb304ef3dcaa95b5b
2022-04-25 20:29:56 -07:00
Derek Mauro
bf66935e07 Remove the legacy internal GTEST_DISALLOW_* macros
PiperOrigin-RevId: 443715444
Change-Id: I3ffd54b63d2728ae4a668ee7875c8c3c8188087c
2022-04-22 11:26:03 -07:00
Derek Mauro
b85864c647 Eliminate the legacy GTEST_COMPILE_ASSERT_ macro
PiperOrigin-RevId: 443462203
Change-Id: I0c43f981663a7531ff5da4d4be01fb3d6762273d
2022-04-21 13:23:32 -07:00
Mike Hommey
d5ad28dbe1 Always initialize fields in MatcherBase constructors
This fixes -Wuninitialized warnings with GCC.

Fixes #3514.
2022-04-20 10:42:11 +09:00
Derek Mauro
25dcdc7e8b Use the Abseil flags library when Abseil is present
When built with `--define=absl=1` under Bazel, GoogleTest
flags use ABSL_FLAG instead of GoogleTest's own implementation.

There are some minor behavior differences in this mode.

The most notable difference is that unrecognized flags result
in a flag parsing error, and are not returned to the user though
a modified argc/argv, unless they appear after the positional
argument delimiter ("--").

For example, to pass a non-Abseil flag, you would have to do
./mytest --gtest_color=false -- --myflag=myvalue

The documentation at https://abseil.io/docs/cpp/guides/flags
may be helpful in understanding the behavior.

There are some other minor differences. For example,
passing --help results in the program returning 1 instead of 0.

https://github.com/google/googletest/issues/3646

PiperOrigin-RevId: 439312700
Change-Id: Id696a25f50f24a5b1785c45ca8fa59794f86fd5c
2022-04-04 07:39:03 -07:00
Copybara-Service
0affd45b62 Merge pull request #3779 from messerb5467:promote-inclusive-behavior
PiperOrigin-RevId: 436579789
Change-Id: I19faae341027efba83f1c2b3839636fc95780fc7
2022-03-22 14:59:23 -07:00
Abseil Team
5d6f38c1e2 Only print disabled test banner if the test matches gtest_filter
Currently, the "[ DISABLED ]" banner is printed for every test in a suite.
When iterating on a single test gtest_filter this is very noisy.

PiperOrigin-RevId: 436489088
Change-Id: If337087a7a0986b073fabf2b0a55d26485eb5c37
2022-03-22 09:07:51 -07:00
Brad Messer
9e71237221
Merge branch 'main' into promote-inclusive-behavior 2022-03-18 12:32:39 -04:00
Brad Messer
794da715d4 Remove sanity as it is offensive to neurodiverse individuals. 2022-03-18 12:19:38 -04:00
Abseil Team
b007c54f29 Running clang-format over all of GoogleTest
A few tests are examining code locations and looking af the resulting line
numbers to verify that GoogleTest shows those to users correctly. Some of those
locations change when clang-format is run. For those locations, I've wrapped
portions in:
// clang-format off
...
// clang-format on

There may be other locations that are currently not tickled by running
clang-format.

PiperOrigin-RevId: 434844712
Change-Id: I3a9f0a6f39eff741c576b6de389bef9b1d11139d
2022-03-15 13:42:11 -07:00
Copybara-Service
8a422b8398 Merge pull request #3774 from sobczyk:main
PiperOrigin-RevId: 434738675
Change-Id: I7c8de4004bac6b750674d19e3e79c0695a42652e
2022-03-15 06:55:30 -07:00
Dino Radakovic
ae5e06dd35 Remove references to deleted script gen_gtest_pred_impl.py
PiperOrigin-RevId: 434464892
Change-Id: Iaa2277f26d0049b3d792e87f64679774a28205c6
2022-03-14 08:00:38 -07:00
Szymon Sobik
5c1b42a58d Adjust xml and json unit tests to test for source file and line location. 2022-03-08 01:15:20 +01:00
Szymon Sobik
ee5e3043ce Add support for testing of xml and json output of source file and line location 2022-03-08 01:14:21 +01:00
Szymon Sobik
f7621f0191 Output source file path and line number in xml and json files.
It outputs the location of testcase only.
Standalone EXPECT will have no location.
2022-03-08 01:12:35 +01:00
Abseil Team
ea55f1f52c Address conversion warning by explicitly casting to size_t
Closes #3762

PiperOrigin-RevId: 428593750
Change-Id: Ifac216568fbc7d999adb71996ec6a1bbe3b97412
2022-02-14 13:28:28 -08:00
Copybara-Service
06519cedc3 Merge pull request #3751 from noiseless:gtest-help-test-OpenBSD
PiperOrigin-RevId: 427207981
Change-Id: Ib93f8f61bf568d4651f9148fbc522288308c0d71
2022-02-08 09:11:25 -08:00
Copybara-Service
504eb98953 Merge pull request #3746 from IYP-Programer-Yeah:use-constant-time-lookup-for-exact-match
PiperOrigin-RevId: 427179775
Change-Id: I9928be2421d559acf0e0f03643ce0b856b63f737
2022-02-08 06:51:54 -08:00
Copybara-Service
43efa0a4ef Merge pull request #3617 from Bagira80:fix_3616
PiperOrigin-RevId: 426976022
Change-Id: Ib9f49cf84775a50cbc806d331349e61a1060b498
2022-02-07 11:51:52 -08:00
Hossein Ghahramanzadeh
d6841c040d Apply requested changes by using std::inserter with move. 2022-02-05 17:43:21 +01:00
Andrew Krasavin
631f4f9947 Fix gtest-help-test failure on OpenBSD 2022-02-05 03:44:54 +03:00
Abseil Team
25ad42aabe GetCurrentOsStackTraceExceptTop (both the method of UnitTestImpl and the wrapper function in gtest.cc) rely on the fact that the inner call is not getting optimized.
This CL annotates them with the appropriate attributes.

PiperOrigin-RevId: 425663217
Change-Id: Ib9ec2a69a7dd98d37640b56d4d7798572da66669
2022-02-01 10:44:59 -08:00
Copybara-Service
4517697675 Merge pull request #3744 from danger89:patch-2
PiperOrigin-RevId: 425519462
Change-Id: I196b22675e471f66929c1cdd0f85a405ebac8484
2022-01-31 20:01:13 -08:00
Hossein Ghahramanzadeh
2eadda6e00 Do constant time matching for exact match filters. 2022-01-31 19:22:37 +01:00
Derek Mauro
28e1da21d8 Finish some missed pieces of the TestCase to TestSuite Migration
PiperOrigin-RevId: 424864779
Change-Id: Iac5cafa3568f5fe41c85c52d28f7d61845f76868
2022-01-28 07:27:11 -08:00
Melroy van den Berg
f2d71f0be2
Let me give a change to try it again - updating to latest version 2022-01-25 22:45:24 +01:00
Abseil Team
f45d5865ed Make recreate_environments_when_repeating=false the default.
So that global test environments are by default set up and torn down once,
regardless of the value of the repeat flag.

The point of global environments is to be set up and torn down once, and shared
by all tests in the process. There is no obvious reason why multiple runs of the
same test should be treated distinctly from single runs of different tests.

Having this be false by default means that repeats using a global environment
run faster. It can still be set to true if it's desired that every repeat get a
fresh environment, but this seems less important given the nature of a global
environment. Every test I've seen using a global environment uses it to set up
some expensive external resource, not something that can/should be set up for
each test anew. (Again this is unsurprising, since the environment is a global.)

PiperOrigin-RevId: 424003937
Change-Id: I9e8a825cb8900960dd65b85fe5ffcc0a337e57f3
2022-01-24 23:46:52 -08:00
Copybara-Service
f64cf6b7b8 Merge pull request #3732 from joshiayush:i2174
PiperOrigin-RevId: 423906844
Change-Id: I1c34a3ce8a5c761ef9f1d7ce48bef8826742e97d
2022-01-24 14:08:19 -08:00
Copybara-Service
3d81736c97 Merge pull request #3615 from IYP-Programer-Yeah:fix-per-test-filter-processing
PiperOrigin-RevId: 423326942
Change-Id: I913f31960d7917b176c9f390424630708473837a
2022-01-21 08:18:49 -08:00
Abseil Team
2ddfdf819d Factor out AssertionResult into dedicated gtest-assertion-result header + implementation files to prevent cyclic includes between gtest.h and gtest_pred_impl.h
PiperOrigin-RevId: 422863083
Change-Id: I299018a860152216adc206780c32923c03bedb2a
2022-01-19 11:31:36 -08:00
Abseil Team
100f6fbf5f Consistently apply IWYU pragmas across googletest and googlemock headers
PiperOrigin-RevId: 422559250
Change-Id: I9f630f2186724950e5e9fbd7093d5264e8bf0a71
2022-01-18 08:11:11 -08:00
Copybara-Service
c9643a2e45 Merge pull request #3721 from joshiayush:i3719
PiperOrigin-RevId: 422405356
Change-Id: I8ea22485d9a25dce81a28d0c323a73b36d15e912
2022-01-17 12:59:48 -08:00
Ayush Joshi
ca3ffd90f2 FIX #2174 -- remove DEBUG_POSTFIX
while this is not synced with the pkg-config file, it only breaks things

Fix #2174

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2022-01-13 21:24:56 +05:30
Copybara-Service
aea0874c42 Merge pull request #3725 from bsilver8192:remove-another-disallow-assign
PiperOrigin-RevId: 421044680
Change-Id: If585089811f1b67eab6f339125c27174ee5bc290
2022-01-11 09:01:32 -08:00
Copybara-Service
1d9f7c5fb2 Merge pull request #3713 from PhilipMourdjis:cmake-qnx-link-regex
PiperOrigin-RevId: 420863433
Change-Id: Ie8c43caff6fb2493ecd47bed50de9db87221f46f
2022-01-10 14:56:50 -08:00
Hossein Ghahramanzadeh
29bc520e5b Fix a typo in comments. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
4fc151ae69 Use normal for loop instead of accumulate. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
aea981dd54 Improve code readablity. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
4adbc9c9b2 Apply requested changes to preserve old behavior. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
d03d23a6e5 Reimplement MatchesFilter with new interfaces. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
3fc1ab6632 Apply requested changes. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
f20688737a Get rid of redundant filter matching code 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
f5b4efef5f Add comments describing the behavior of filters 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
2377c8d32b Process filter string once instead of per test 2022-01-06 15:46:52 +01:00
Ayush Joshi
1b4cf35958 FIX #3719 -- Fix clang conversion warnings
We should perform an explicit type conversion to `unsigned char` before passing the
`const char` data to `IsValidXmlCharacter()` and `IsNormalizableWhitespace()` functions
in order to avoid compile time conversion warnings

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2022-01-01 19:28:21 +05:30
Derek Mauro
c58f562fa2 Makes the Python imports consistently use full paths from the repository root,
unifying the behavior between Bazel and CMake

This fixes one of the CI failures on Windows

PiperOrigin-RevId: 417872531
Change-Id: I156989323b7e6d4a4420f4f9691b078829db933d
2021-12-22 13:01:24 -08:00
Derek Mauro
71d4e2f742 Makes TestForDeathTest.CRTDebugDeath only run when _DEBUG is defined
PiperOrigin-RevId: 417678422
Change-Id: I8e42a906459b8fd5a7789a7ed728d12448046c44
2021-12-21 13:16:17 -08:00
Philip Mourdjis
4745746725 link to regex on qnx in cmake 2021-12-21 16:14:03 +00:00
Dino Radakovic
97a467571a Release tests for UnitTestOptions::MatchesFilter
PiperOrigin-RevId: 416567004
Change-Id: Ic407e0fcdf8ffd1c012a1b12df2837bdac1dccb4
2021-12-15 08:36:08 -08:00
Copybara-Service
054a986a85 Merge pull request #3694 from joshiayush:main
PiperOrigin-RevId: 415014511
Change-Id: If2e20eb9408a23b5574a2c87f651c2905f14fcac
2021-12-08 08:53:55 -08:00