gitMirror/googletest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,137 Commits 1 Branch 0 Tags 14 MiB
23142843f7
Commit Graph

1580 Commits

Author SHA1 Message Date
Tom Hughes
23142843f7 Use "#ifdef GTEST_OS_..." instead of "#if GTEST_OS_..." 
This is compatible with compiling with "-Wundef" (#3267).

PiperOrigin-RevId: 513943378
Change-Id: I47cf5fabbb77be061c4483a0adc54511af6b191c
 2023-03-06 07:14:21 -08:00
Abseil Team
8aa75fa771 Eliminate argv list action parameter. 
PiperOrigin-RevId: 512791992
Change-Id: Ie7fc37ea06ea7d9f595268c9ec84a0e144c297bb
 2023-02-27 18:47:21 -08:00
Copybara-Service
c7d0bc8309 Merge pull request #4164 from sergio-nsk:patch-2 
PiperOrigin-RevId: 512753220
Change-Id: I3f7ad6c62c738d1d7405c50924b36deac8a9ac85
 2023-02-27 15:49:24 -08:00
Phoebe Liang
6882aa0987 Reorder printers list. 
PiperOrigin-RevId: 512708763
Change-Id: I1f24f2e1d17359aee5aa4cdf614c9357872ca03b
 2023-02-27 13:03:15 -08:00
Abseil Team
3d787f5a0d Add const qualifier to gtest_sentinel which doesn't change. 
PiperOrigin-RevId: 512094429
Change-Id: I29b116da65bc7471c43021d1650d90f7b2a685c2
 2023-02-24 09:50:32 -08:00
Dino Radakovic
39a26e12d6 Avoid redundant declaration of static constexpr members in c++17 
Keep declarations in c++ < 17 using new macro, GTEST_INTERNAL_NEED_REDUNDANT_CONSTEXPR_DECL.

Fixes #4148.

PiperOrigin-RevId: 511510401
Change-Id: I76c3f2fccf07a0978adcbe5f8f0203b9d0c33872
 2023-02-22 09:02:55 -08:00
Sergey
10493e3854
Fix error in_death_test_child_process: undeclared identifier 
The error occurs if !GTEST_HAS_DEATH_TEST on Windows.
 2023-02-21 13:29:20 -07:00
Tom Hughes
750d67d809 Remove int64_t cast in RecordProperty 
Historically, calls to RecordProperty with values that are convertible to
int64_t have been casted to int64_t. The result was that types like float or
double would be truncated when printed (e.g., 4.75 -> 4). This change removes
the cast so that the types are printed in a more appropriate manner.

PiperOrigin-RevId: 511238685
Change-Id: I80de5db14462da2a3e1f476086025ae514383a17
 2023-02-21 10:25:39 -08:00
Abseil Team
f063cd25c9 Remove strdup usage 
PiperOrigin-RevId: 509947007
Change-Id: I31e1274afa889776829c877c40c9af589298dcf2
 2023-02-15 15:22:10 -08:00
Abseil Team
2057566e4e Remove some filesystem APIs and tests under !GTEST_HAS_FILE_SYSTEM 
PiperOrigin-RevId: 509537606
Change-Id: I68f7054e34b1fe76c1fd85099fffa4ee3c2b00c0
 2023-02-14 08:33:42 -08:00
Abseil Team
b80a07ffe6 Avoid reliance on <any> header without RTTI on MSVC 
Fixes: #4144
PiperOrigin-RevId: 509322023
Change-Id: I52bdf6c25ff433327e174d3f9583b3d50b872d58
 2023-02-13 13:46:03 -08:00
Tom Hughes
b73f27fd16 Fix _MSC_VER check 
Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent
with other usages in googletest and to work with the "-Wundef" warning.

PiperOrigin-RevId: 508087630
Change-Id: I29c16fd2fa51a9dfecd55e10362a020318318956
 2023-02-08 08:29:54 -08:00
Tom Hughes
0570e2d930 Remove GTEST_USES_PCRE references 
Nothing defines GTEST_USES_PCRE anymore. It was only meant for
internal use, so nothing public should be relying on it:
https://github.com/google/googletest/issues/2735#issuecomment-644849438.

Found when compiling with "-Wundef".

Fixes #2735.

PiperOrigin-RevId: 507823660
Change-Id: Ie19e576ff01dc3b16381338578ece92adccfc09b
 2023-02-07 10:38:08 -08:00
Tom Hughes
deaf5615f1 Fix -Wsign-conversion warnings 
googletest/test/gtest_xml_outfile2_test_.cc:48:39:
warning: implicit conversion turns floating-point number into integer:
'float' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestFloatProperty", float_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:51:40:
warning: implicit conversion turns floating-point number into integer:
'double' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestDoubleProperty", double_prop);
  ~~~~~~~~~~~~~~                       ^~~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:57:39:
warning: implicit conversion changes signedness:
'size_t' (aka 'unsigned long') to 'int64_t' (aka 'long') [-Wsign-conversion]
  RecordProperty("TestSizetProperty", size_t_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~~
PiperOrigin-RevId: 506644143
Change-Id: I9c2cd5f52daebe25e73bb97f696687797ed2cabf
 2023-02-02 09:31:44 -08:00
Tom Hughes
4f7c63d991 Remove unneccessary "#if _MSC_VER" 
The GTEST_DISABLE_MSC_WARNINGS macros already have an _MSC_VER check.
This change also adds a missing GTEST_DISABLE_MSC_WARNINGS_POP_ in
gtest-typed-test_test.cc.

PiperOrigin-RevId: 506636248
Change-Id: Ifdc044528f5448fbf0175887d1671f1e1f3040b9
 2023-02-02 09:02:17 -08:00
Abseil Team
6f21175f57 Add a trailing decimal point to FormatTimeInMillisAsSeconds() output when input 
is an exact N seconds.

PiperOrigin-RevId: 506610898
Change-Id: Idcd705c719e0e721148c350c8a14f27b9eb5c4f7
 2023-02-02 07:15:23 -08:00
Tom Hughes
fd36851c8d Build gmock Python tests when building with cmake 
Fixes #4124.

PiperOrigin-RevId: 506379032
Change-Id: Ibc44ffce1012bbf313565728a3d9e5e6e56ba660
 2023-02-01 11:44:56 -08:00
Tom Hughes
d9251171f5 Fix sign conversion warning from clang: 
googletest/samples/prime_tables.h:81:57: error:
implicit conversion changes signedness: 'int' to 'unsigned long'
[-Werror,-Wsign-conversion]
      : is_prime_size_(max + 1), is_prime_(new bool[max + 1]) {
                                           ~~~      ~~~~^~~

PiperOrigin-RevId: 506065360
Change-Id: Ida4550562531012c089e2f9fcf530b3a78889fa3
 2023-01-31 11:37:10 -08:00
Tom Hughes
4fb7039fda Use GTEST_DISABLE_MSC_WARNINGS macros to disable warnings 
Prior to this change we had a mixture of pragmas and
GTEST_DISABLE_MSC_WARNINGS; this change consolidates all instances
to use the macros.

PiperOrigin-RevId: 505786926
Change-Id: I2be8f6304387393995081af42ed32c2ad1bba5a7
 2023-01-30 13:45:46 -08:00
Tom Hughes
b72202078d Test current behavior of doubles and floats in RecordProperty 
PiperOrigin-RevId: 505104193
Change-Id: I4c2758f22ee1321ed6b6662ab2668f6c5b6aa661
 2023-01-27 06:38:52 -08:00
Tom Hughes
403a968d3c Fix formatting in Python files 
PiperOrigin-RevId: 504890435
Change-Id: Ia9a89d0d7a07fe70c12f7f0202c8256c94d2f118
 2023-01-26 11:06:14 -08:00
Tom Hughes
0194f90d0e Fix Python docstrings to match style guide 
https://google.github.io/styleguide/pyguide.html#s3.8.3-functions-and-methods

PiperOrigin-RevId: 504857416
Change-Id: I7815ce27e454a120b3974ae7e2bea952108b836c
 2023-01-26 09:04:40 -08:00
Tom Hughes
b495f72f1f Use more specific assertLess instead of assertTrue 
PiperOrigin-RevId: 504670738
Change-Id: Ib68b676403204098e89f536f9b8317f9f717c24d
 2023-01-25 15:01:21 -08:00
Tom Hughes
f47d75faf3 Fix pylint warning 
Possible unbalanced tuple unpacking with sequence defined at line N:
left side has 1 label(s), right side has 0 value(s)
[unbalanced-tuple-unpacking]

PiperOrigin-RevId: 504640001
Change-Id: If8d6038a9acf74a409cb6b6ee30cea7745b4b303
 2023-01-25 13:03:31 -08:00
Tom Hughes
137dcd18cc Remove pylint disable comments that no longer trigger warnings 
PiperOrigin-RevId: 504633130
Change-Id: I3fdbc83975fea97aa53f7325d323adead0a30e24
 2023-01-25 12:35:34 -08:00
Tom Hughes
d1ad27e0a4 Fix formatting in subset of Python files 
These files were formatted with automated tools. The remaining Python
files require some manual fix ups, so they will be fixed separately.

PiperOrigin-RevId: 504579820
Change-Id: I3923bd414bffe3ded6163ec496cd09ace3951928
 2023-01-25 09:14:26 -08:00
Tom Hughes
6c65a1ca35 Replace numeric lints with their string equivalent 
PiperOrigin-RevId: 504570278
Change-Id: Iab9c988b3a781eaafbdd97c924a74c2269125799
 2023-01-25 08:32:19 -08:00
Tom Hughes
2491710524 Fix formatting of C++ files 
PiperOrigin-RevId: 504325204
Change-Id: Iaa1d6d0ab1dccaaeef26f9cb109d530835499240
 2023-01-24 11:10:09 -08:00
Tom Hughes
408471e20c Fix formatting of Markdown files 
PiperOrigin-RevId: 504308485
Change-Id: Ia4ae97b2173b44b89aa5d987ddefd6e0c1488386
 2023-01-24 10:13:03 -08:00
Derek Mauro
544c96ed5b Remove FloatingPoint::Max() in favor of std::numeric_limits::max() 
In #4113 a user says Max clashes with a macro. Since it is only used in
a test, use std::numeric_limits::max() instead.

Note that in headers, the macro issue can be mitigated with
parenthesis like this: `(std::numeric_limits<T>::max)()`

PiperOrigin-RevId: 504284906
Change-Id: Ibf430caec1a6afdf6b303534fec6a4fd00a6373f
 2023-01-24 08:41:35 -08:00
Tom Hughes
bdb3b0a493 Replace deprecated python calls 
assert_ -> assertTrue/assertFalse/assertIn/assertNotIn
assertEquals -> assertEqual

PiperOrigin-RevId: 502654909
Change-Id: I25d30095a83c3806606cb80d676b3c979495e6bd
 2023-01-17 12:16:29 -08:00
Tom Hughes
5cd81a7848 Fix -Wimplicit-int-float-conversion warning 
We're intentionally losing precision in this case, so add a cast.

googletest/googletest/include/gtest/gtest-printers.h:532:9: error:
implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision
[-Werror,-Wimplicit-int-float-conversion]
    if (static_cast<int32_t>(val * mulfor6 + 0.5) / mulfor6 == val) return 6;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~

googletest/googletest/include/gtest/gtest-printers.h:544:9: error:
implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision
[-Werror,-Wimplicit-int-float-conversion]
    if (static_cast<int32_t>(val / divfor6 + 0.5) * divfor6 == val) return 6;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~

PiperOrigin-RevId: 502646042
Change-Id: I05989ee42675b531a9907616c9582a5a7c77bed6
 2023-01-17 11:44:46 -08:00
Derek Mauro
9d697cc81c Update documentation for v1.13.0 
PiperOrigin-RevId: 502644180
Change-Id: Id20b5e4eec22035da278f1767002657f66dbe79c
 2023-01-17 11:38:05 -08:00
Derek Mauro
b5401fef68 Add an explicit #error that C++ versions less than C++14 are not supported 
PiperOrigin-RevId: 501568410
Change-Id: I0f78cd96dc9204c8ec97a1cdd09a9d63a613cc5b
 2023-01-12 08:10:36 -08:00
Tom Hughes
9345421658 Fix GTEST_OS_ESP8266 check 
Everywhere else in the code, we check the value of GTEST_OS_ESP8266, not just
whether it is defined.

PiperOrigin-RevId: 499946909
Change-Id: I86f7e8947abb4e928fc24d1416d8237987b27845
 2023-01-05 11:15:29 -08:00
Tom Hughes
e5e46b09a1 IWYU: Add missing std includes 
PiperOrigin-RevId: 499893032
Change-Id: I33304802b7c82ae2d008f3ee89df38866e5f57ba
 2023-01-05 08:44:01 -08:00
Derek Mauro
0296d7d370 Workaround for GCC12 bug illustrated by https://godbolt.org/z/Pe5aE59xG 
Fixes #4108

PiperOrigin-RevId: 499556061
Change-Id: I1cb1564f9b77e1825fddc9236965f4a3b661d96a
 2023-01-04 12:50:14 -08:00
Tom Hughes
3a99ab6d83 Fix _MSC_VER check 
Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent with other usages in the file and to work with the "-Wundef" warning.

PiperOrigin-RevId: 499471290
Change-Id: I34a9442eecf266afd74d4332cab7d39766df4ed9
 2023-01-04 06:40:48 -08:00
Abseil Team
b0846aaf37 Introduces a new porting flag (GTEST_HAS_FILE_SYSTEM) to indicate whether a platform supports filesystem operations. 
PiperOrigin-RevId: 494751986
Change-Id: I07f73bdf478a73934b8f1a69c1ab4abda1b231ae
 2022-12-12 09:34:12 -08:00
Tom Hughes
516940f16d Fall back to the system clock when building with newlib on a system without a monotonic clock. 
PiperOrigin-RevId: 493917905
Change-Id: I20137cfcda3671ffc8edcda2b6554aa392e3a00a
 2022-12-08 09:34:13 -08:00
Derek Mauro
97459e54ec Remove the unused class TestNameIs 
Fixes #4076

PiperOrigin-RevId: 493158910
Change-Id: Id66c0443a6f5f4d167ae39ac79766b32cf95a383
 2022-12-05 17:39:39 -08:00
Abseil Team
9c332145b7 When printing floating-point numbers, print full precision by default. 
To make debug output readable, we still use the faster 6-digit precision
sometimes, but only if it will round-trip.

This way, when a test fails due to a very small difference in floating-point
numbers, users will have enough digits to see the difference.

PiperOrigin-RevId: 488958311
Change-Id: Ibcac43f48a97006d89217530c69386cc4fa2735c
 2022-11-16 09:18:37 -08:00
Abseil Team
4408a0288b Remove incorrect usage of GTEST_ATTRIBUTE_UNUSED_ on classes. 
Fixes: #4054
PiperOrigin-RevId: 488721587
Change-Id: I8742d8475376635c83edcf524796a6107042e89b
 2022-11-15 12:01:35 -08:00
Copybara-Service
0e6aac2571 Merge pull request #4058 from zloylos:support-kitty-term 
PiperOrigin-RevId: 488463135
Change-Id: I4180d766dabbe438210904e743e6e963122540f5
 2022-11-14 14:06:58 -08:00
Copybara-Service
42c6f57f3c Merge pull request #4060 from RerEngineer:main 
PiperOrigin-RevId: 488456139
Change-Id: I648f3d2c6affadfea27214a6a22cacc576971cef
 2022-11-14 13:40:08 -08:00
RerEngineer
9c990a7b1e fixing gcc.gnu domain redirection 2022-11-12 15:12:00 +00:00
Abseil Team
912db74253 Defined a testing::SrcDir() function that returns the name of a directory 
where ancillary data files can be found.

PiperOrigin-RevId: 487896836
Change-Id: Ie6b1ba734e900fa33872b63090879ee6efe33411
 2022-11-11 12:59:10 -08:00
Denis Hananein
4b7f9453c5 Support kitty TERM 
Signed-off-by: Denis Hananein <i@zloylos.me>
 2022-11-10 17:08:48 +01:00
Copybara-Service
44c03643cf Merge pull request #4039 from zloylos:fix-return-fail-at-4038 
PiperOrigin-RevId: 487516335
Change-Id: Ib475750586fc7e6ab01729f65253e3a86916b994
 2022-11-10 06:13:31 -08:00
Abseil Team
386c7665f5 RecordProperty serializes ints and 64-bit ints, including size_ts 
PiperOrigin-RevId: 486685761
Change-Id: I164d2646e65670d341dbf437ee571953c456677a
 2022-11-07 09:36:56 -08:00