From e9fb5c7bacc4a25b030569c92ff9f6925288f1c3 Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Fri, 24 Mar 2023 05:57:22 -0700 Subject: [PATCH] Replace `const char*` with `absl::string_view` as the latter is preferred. PiperOrigin-RevId: 519122695 Change-Id: I7dcf969d15d26ccc4b376e3ab6db7f4c08c7386f --- docs/advanced.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/advanced.md b/docs/advanced.md index d0369237..3871db13 100644 --- a/docs/advanced.md +++ b/docs/advanced.md @@ -1066,7 +1066,7 @@ they must be declared **public** rather than **protected** in order to use ```c++ class FooTest : - public testing::TestWithParam { + public testing::TestWithParam { // You can implement all the usual fixture class members here. // To access the test parameter, call GetParam() from class // TestWithParam. @@ -1077,7 +1077,7 @@ class BaseTest : public testing::Test { ... }; class BarTest : public BaseTest, - public testing::WithParamInterface { + public testing::WithParamInterface { ... }; ``` @@ -1148,8 +1148,8 @@ with parameter values `"cat"` and `"dog"` using the [`ValuesIn`](reference/testing.md#param-generators) parameter generator: ```c++ -const char* pets[] = {"cat", "dog"}; -INSTANTIATE_TEST_SUITE_P(Pets, FooTest, testing::ValuesIn(pets)); +constexpr absl::string_view kPets[] = {"cat", "dog"}; +INSTANTIATE_TEST_SUITE_P(Pets, FooTest, testing::ValuesIn(kPets)); ``` The tests from the instantiation above will have these names: