From cbf46d3f278a88bf167cb03a37c5dcd8d01fe3bf Mon Sep 17 00:00:00 2001 From: dmauro Date: Thu, 28 Oct 2021 10:22:51 -0400 Subject: [PATCH] Googletest export Guard #includes for threading related headers with GTEST_IS_THREADSAFE Some platforms that don't support threading give errors for including these headers PiperOrigin-RevId: 406133623 --- .../include/gtest/internal/gtest-port.h | 23 +++++++++++-------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/googletest/include/gtest/internal/gtest-port.h b/googletest/include/gtest/internal/gtest-port.h index 63ef13c1..cc6fa6b3 100644 --- a/googletest/include/gtest/internal/gtest-port.h +++ b/googletest/include/gtest/internal/gtest-port.h @@ -260,9 +260,17 @@ #include #include +// #include // Guarded by GTEST_IS_THREADSAFE below #include +#include #include +#include +#include +#include +// #include // Guarded by GTEST_IS_THREADSAFE below +#include #include +#include #ifndef _WIN32_WCE # include @@ -274,15 +282,6 @@ # include #endif -#include // NOLINT -#include -#include -#include -#include // NOLINT -#include -#include -#include - #include "gtest/internal/custom/gtest-port.h" #include "gtest/internal/gtest-port-arch.h" @@ -759,6 +758,12 @@ typedef struct _RTL_CRITICAL_SECTION GTEST_CRITICAL_SECTION; #endif // GTEST_IS_THREADSAFE +#if GTEST_IS_THREADSAFE +// Some platforms don't support including these threading related headers. +#include // NOLINT +#include // NOLINT +#endif // GTEST_IS_THREADSAFE + // GTEST_API_ qualifies all symbols that must be exported. The definitions below // are guarded by #ifndef to give embedders a chance to define GTEST_API_ in // gtest/internal/custom/gtest-port.h