gitMirror/googletest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixup some missing overrides in googletest.

Browse Source 
This CL adds a couple missing overrides in the googletest sources.
These were found downstream when -Wsuggest-override and
-Wsuggest-destructor-override were enabled.

PiperOrigin-RevId: 447754883
Change-Id: I7bf35a8757cbc5ae157827037aa3d13f47392406
This commit is contained in:
Abseil Team 2022-05-10 09:38:54 -07:00 committed by Copybara-Service
parent 4348d4efed
commit bda85449f4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
googletest/include/gtest/internal/gtest-port.h
View File

@ -1530,7 +1530,7 @@ class ThreadLocal : public ThreadLocalBase {
explicit ThreadLocal(const T& value) explicit ThreadLocal(const T& value)
: default_factory_(new InstanceValueHolderFactory(value)) {} : default_factory_(new InstanceValueHolderFactory(value)) {}
~ThreadLocal() { ThreadLocalRegistry::OnThreadLocalDestroyed(this); } ~ThreadLocal() override { ThreadLocalRegistry::OnThreadLocalDestroyed(this); }
T* pointer() { return GetOrCreateValue(); } T* pointer() { return GetOrCreateValue(); }
const T* pointer() const { return GetOrCreateValue(); } const T* pointer() const { return GetOrCreateValue(); }
@ -1559,7 +1559,7 @@ class ThreadLocal : public ThreadLocalBase {
->pointer(); ->pointer();
} }
virtual ThreadLocalValueHolderBase* NewValueForCurrentThread() const { ThreadLocalValueHolderBase* NewValueForCurrentThread() const override {
return default_factory_->MakeNewHolder(); return default_factory_->MakeNewHolder();
} }