From 6c8a386513b70cb43df997b6406ae5c39f5c9b88 Mon Sep 17 00:00:00 2001 From: dmauro Date: Tue, 9 Nov 2021 16:35:30 -0500 Subject: [PATCH] Googletest export Explicitly used unsigned chars for testing for valid XML characters PiperOrigin-RevId: 408692969 --- googletest/src/gtest.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc index 3eb9505f..103c4457 100644 --- a/googletest/src/gtest.cc +++ b/googletest/src/gtest.cc @@ -3934,12 +3934,13 @@ class XmlUnitTestResultPrinter : public EmptyTestEventListener { private: // Is c a whitespace character that is normalized to a space character // when it appears in an XML attribute value? - static bool IsNormalizableWhitespace(char c) { - return c == 0x9 || c == 0xA || c == 0xD; + static bool IsNormalizableWhitespace(unsigned char c) { + return c == '\t' || c == '\n' || c == '\r'; } // May c appear in a well-formed XML document? - static bool IsValidXmlCharacter(char c) { + // https://www.w3.org/TR/REC-xml/#charsets + static bool IsValidXmlCharacter(unsigned char c) { return IsNormalizableWhitespace(c) || c >= 0x20; }