gitMirror/googletest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Googletest export

Browse Source 
Launder buffer before reference

In GCC, directly casting the Buffer reference to another type results in
strict-aliasing violation errors. This launders the reference using an
intermediate pointer prior to creating the new reference.

PiperOrigin-RevId: 350809323
This commit is contained in:
Abseil Team 2021-01-08 15:00:47 -05:00 committed by Derek Mauro
parent c13c27a513
commit 50ce520161
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
googletest/include/gtest/gtest-matchers.h
View File

@ -421,7 +421,11 @@ class MatcherBase : private MatcherDescriberInterface {
template <typename M, bool = IsInlined<M>()> template <typename M, bool = IsInlined<M>()>
struct ValuePolicy { struct ValuePolicy {
static const M& Get(const MatcherBase& m) { static const M& Get(const MatcherBase& m) {
return reinterpret_cast<const M&>(m.buffer_); // When inlined along with Init, need to be explicit to avoid violating
// strict aliasing rules.
const M *ptr = static_cast<const M*>(
static_cast<const void*>(&m.buffer_));
return *ptr;
} }
static void Init(MatcherBase& m, M impl) { static void Init(MatcherBase& m, M impl) {
::new (static_cast<void*>(&m.buffer_)) M(impl); ::new (static_cast<void*>(&m.buffer_)) M(impl);