Use normal for loop instead of accumulate.

This commit is contained in:
Hossein Ghahramanzadeh 2021-12-22 16:22:56 +01:00
parent aea981dd54
commit 4fc151ae69

View File

@ -50,7 +50,6 @@
#include <limits>
#include <list>
#include <map>
#include <numeric>
#include <ostream> // NOLINT
#include <sstream>
#include <vector>
@ -771,10 +770,11 @@ class PositiveAndNegativeUnitTestFilter {
// TODO: Fail on multiple '-' characters
// For the moment to preserve old behavior we concatenate the rest of the
// string parts with `-` as separator to generate the negative filter.
negative_filter_ = UnitTestFilter{std::accumulate(
positive_and_negative_filters.begin() + 2,
positive_and_negative_filters.end(), positive_and_negative_filters[1],
[](const std::string& lhs, const std::string& rhs) { return lhs + '-' + rhs; })};
auto negative_filter_string = positive_and_negative_filters[1];
for (std::size_t i = 2; i < positive_and_negative_filters.size(); i++)
negative_filter_string =
negative_filter_string + '-' + positive_and_negative_filters[i];
negative_filter_ = UnitTestFilter{negative_filter_string};
} else {
// In case we don't have a negative filter and positive filter is ""
// we do not use kUniversalFilter by design as opposed to when we have a