From 4fc151ae6910c250329f72d9254b4a32634c696a Mon Sep 17 00:00:00 2001 From: Hossein Ghahramanzadeh Date: Wed, 22 Dec 2021 16:22:56 +0100 Subject: [PATCH] Use normal for loop instead of accumulate. --- googletest/src/gtest.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc index 959b3bbe..54814d82 100644 --- a/googletest/src/gtest.cc +++ b/googletest/src/gtest.cc @@ -50,7 +50,6 @@ #include #include #include -#include #include // NOLINT #include #include @@ -771,10 +770,11 @@ class PositiveAndNegativeUnitTestFilter { // TODO: Fail on multiple '-' characters // For the moment to preserve old behavior we concatenate the rest of the // string parts with `-` as separator to generate the negative filter. - negative_filter_ = UnitTestFilter{std::accumulate( - positive_and_negative_filters.begin() + 2, - positive_and_negative_filters.end(), positive_and_negative_filters[1], - [](const std::string& lhs, const std::string& rhs) { return lhs + '-' + rhs; })}; + auto negative_filter_string = positive_and_negative_filters[1]; + for (std::size_t i = 2; i < positive_and_negative_filters.size(); i++) + negative_filter_string = + negative_filter_string + '-' + positive_and_negative_filters[i]; + negative_filter_ = UnitTestFilter{negative_filter_string}; } else { // In case we don't have a negative filter and positive filter is "" // we do not use kUniversalFilter by design as opposed to when we have a