From 48a1b110583dd55e5076952b2acd772d9aaf6372 Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Wed, 8 Mar 2023 15:09:58 -0800 Subject: [PATCH] Add a comment to clarify Fuchsia process launcher requirement. PiperOrigin-RevId: 515154129 Change-Id: I3dd9e912e160d09d1f74a467336212701d4e1b7d --- googletest/src/gtest-death-test.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/googletest/src/gtest-death-test.cc b/googletest/src/gtest-death-test.cc index 649b17b5..1bf2f312 100644 --- a/googletest/src/gtest-death-test.cc +++ b/googletest/src/gtest-death-test.cc @@ -1024,6 +1024,11 @@ DeathTest::TestRole FuchsiaDeathTest::AssumeRole() { GTEST_DEATH_TEST_CHECK_(status == ZX_OK); // Spawn the child process. + // Note: The test component must have `fuchsia.process.Launcher` declared + // in its manifest. (Fuchsia integration tests require creating a + // "Fuchsia Test Component" which contains a "Fuchsia Component Manifest") + // Launching processes is a privileged operation in Fuschia, and the + // declaration indicates that the ability is required for the component. std::unique_ptr argv = CreateArgvFromArgs(args); status = fdio_spawn_etc(child_job, FDIO_SPAWN_CLONE_ALL, argv[0], argv.get(), nullptr, 2, spawn_actions,