From 2828773179fa425ee406df61890a150577178ea2 Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Tue, 27 Oct 2020 16:56:33 -0400 Subject: [PATCH] Googletest export Remove obsolete comment about non-const references. They used to be banned by the C++ style guide, but positions shifted, and this comment is no longer up to date. There's another reference (heh) on lines 816-819 to how gmock is a "general framework", with the possible implication that support for non-const references was weird in some way and only there to be "general", but I left it alone because I don't really feel I understand what it's saying. PiperOrigin-RevId: 339323428 --- googlemock/include/gmock/gmock-matchers.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/googlemock/include/gmock/gmock-matchers.h b/googlemock/include/gmock/gmock-matchers.h index 13a46712..7db65a48 100644 --- a/googlemock/include/gmock/gmock-matchers.h +++ b/googlemock/include/gmock/gmock-matchers.h @@ -1717,9 +1717,6 @@ class FloatingEqMatcher { // The following 3 type conversion operators allow FloatEq(expected) and // NanSensitiveFloatEq(expected) to be used as a Matcher, a // Matcher, or a Matcher, but nothing else. - // (While Google's C++ coding style doesn't allow arguments passed - // by non-const reference, we may see them in code not conforming to - // the style. Therefore Google Mock needs to support them.) operator Matcher() const { return MakeMatcher( new Impl(expected_, nan_eq_nan_, max_abs_error_));