Merge pull request #3573 from cclauss:patch-1
PiperOrigin-RevId: 397998384
This commit is contained in:
commit
09074c1571
@ -1452,7 +1452,7 @@ the pointer is copied. When the last matcher that references the implementation
|
|||||||
object dies, the implementation object will be deleted.
|
object dies, the implementation object will be deleted.
|
||||||
|
|
||||||
Therefore, if you have some complex matcher that you want to use again and
|
Therefore, if you have some complex matcher that you want to use again and
|
||||||
again, there is no need to build it everytime. Just assign it to a matcher
|
again, there is no need to build it every time. Just assign it to a matcher
|
||||||
variable and use that variable repeatedly! For example,
|
variable and use that variable repeatedly! For example,
|
||||||
|
|
||||||
```cpp
|
```cpp
|
||||||
@ -2601,7 +2601,7 @@ efficient. When the last action that references the implementation object dies,
|
|||||||
the implementation object will be deleted.
|
the implementation object will be deleted.
|
||||||
|
|
||||||
If you have some complex action that you want to use again and again, you may
|
If you have some complex action that you want to use again and again, you may
|
||||||
not have to build it from scratch everytime. If the action doesn't have an
|
not have to build it from scratch every time. If the action doesn't have an
|
||||||
internal state (i.e. if it always does the same thing no matter how many times
|
internal state (i.e. if it always does the same thing no matter how many times
|
||||||
it has been called), you can assign it to an action variable and use that
|
it has been called), you can assign it to an action variable and use that
|
||||||
variable repeatedly. For example:
|
variable repeatedly. For example:
|
||||||
@ -4188,7 +4188,7 @@ This implementation class does *not* need to inherit from any particular class.
|
|||||||
What matters is that it must have a `Perform()` method template. This method
|
What matters is that it must have a `Perform()` method template. This method
|
||||||
template takes the mock function's arguments as a tuple in a **single**
|
template takes the mock function's arguments as a tuple in a **single**
|
||||||
argument, and returns the result of the action. It can be either `const` or not,
|
argument, and returns the result of the action. It can be either `const` or not,
|
||||||
but must be invokable with exactly one template argument, which is the result
|
but must be invocable with exactly one template argument, which is the result
|
||||||
type. In other words, you must be able to call `Perform<R>(args)` where `R` is
|
type. In other words, you must be able to call `Perform<R>(args)` where `R` is
|
||||||
the mock function's return type and `args` is its arguments in a tuple.
|
the mock function's return type and `args` is its arguments in a tuple.
|
||||||
|
|
||||||
|
@ -136,7 +136,7 @@ class Predicate1Test : public testing::Test {
|
|||||||
|
|
||||||
// Verifies that the control flow in the test function is expected.
|
// Verifies that the control flow in the test function is expected.
|
||||||
if (expected_to_finish_ && !finished_) {
|
if (expected_to_finish_ && !finished_) {
|
||||||
FAIL() << "The predicate assertion unexpactedly aborted the test.";
|
FAIL() << "The predicate assertion unexpectedly aborted the test.";
|
||||||
} else if (!expected_to_finish_ && finished_) {
|
} else if (!expected_to_finish_ && finished_) {
|
||||||
FAIL() << "The failed predicate assertion didn't abort the test "
|
FAIL() << "The failed predicate assertion didn't abort the test "
|
||||||
"as expected.";
|
"as expected.";
|
||||||
@ -530,7 +530,7 @@ class Predicate2Test : public testing::Test {
|
|||||||
|
|
||||||
// Verifies that the control flow in the test function is expected.
|
// Verifies that the control flow in the test function is expected.
|
||||||
if (expected_to_finish_ && !finished_) {
|
if (expected_to_finish_ && !finished_) {
|
||||||
FAIL() << "The predicate assertion unexpactedly aborted the test.";
|
FAIL() << "The predicate assertion unexpectedly aborted the test.";
|
||||||
} else if (!expected_to_finish_ && finished_) {
|
} else if (!expected_to_finish_ && finished_) {
|
||||||
FAIL() << "The failed predicate assertion didn't abort the test "
|
FAIL() << "The failed predicate assertion didn't abort the test "
|
||||||
"as expected.";
|
"as expected.";
|
||||||
@ -966,7 +966,7 @@ class Predicate3Test : public testing::Test {
|
|||||||
|
|
||||||
// Verifies that the control flow in the test function is expected.
|
// Verifies that the control flow in the test function is expected.
|
||||||
if (expected_to_finish_ && !finished_) {
|
if (expected_to_finish_ && !finished_) {
|
||||||
FAIL() << "The predicate assertion unexpactedly aborted the test.";
|
FAIL() << "The predicate assertion unexpectedly aborted the test.";
|
||||||
} else if (!expected_to_finish_ && finished_) {
|
} else if (!expected_to_finish_ && finished_) {
|
||||||
FAIL() << "The failed predicate assertion didn't abort the test "
|
FAIL() << "The failed predicate assertion didn't abort the test "
|
||||||
"as expected.";
|
"as expected.";
|
||||||
@ -1444,7 +1444,7 @@ class Predicate4Test : public testing::Test {
|
|||||||
|
|
||||||
// Verifies that the control flow in the test function is expected.
|
// Verifies that the control flow in the test function is expected.
|
||||||
if (expected_to_finish_ && !finished_) {
|
if (expected_to_finish_ && !finished_) {
|
||||||
FAIL() << "The predicate assertion unexpactedly aborted the test.";
|
FAIL() << "The predicate assertion unexpectedly aborted the test.";
|
||||||
} else if (!expected_to_finish_ && finished_) {
|
} else if (!expected_to_finish_ && finished_) {
|
||||||
FAIL() << "The failed predicate assertion didn't abort the test "
|
FAIL() << "The failed predicate assertion didn't abort the test "
|
||||||
"as expected.";
|
"as expected.";
|
||||||
@ -1964,7 +1964,7 @@ class Predicate5Test : public testing::Test {
|
|||||||
|
|
||||||
// Verifies that the control flow in the test function is expected.
|
// Verifies that the control flow in the test function is expected.
|
||||||
if (expected_to_finish_ && !finished_) {
|
if (expected_to_finish_ && !finished_) {
|
||||||
FAIL() << "The predicate assertion unexpactedly aborted the test.";
|
FAIL() << "The predicate assertion unexpectedly aborted the test.";
|
||||||
} else if (!expected_to_finish_ && finished_) {
|
} else if (!expected_to_finish_ && finished_) {
|
||||||
FAIL() << "The failed predicate assertion didn't abort the test "
|
FAIL() << "The failed predicate assertion didn't abort the test "
|
||||||
"as expected.";
|
"as expected.";
|
||||||
|
@ -404,7 +404,7 @@ TEST(FormatTimeInMillisAsSecondsTest, FormatsNegativeNumber) {
|
|||||||
|
|
||||||
// Tests FormatEpochTimeInMillisAsIso8601(). The correctness of conversion
|
// Tests FormatEpochTimeInMillisAsIso8601(). The correctness of conversion
|
||||||
// for particular dates below was verified in Python using
|
// for particular dates below was verified in Python using
|
||||||
// datetime.datetime.fromutctimestamp(<timetamp>/1000).
|
// datetime.datetime.fromutctimestamp(<timestamp>/1000).
|
||||||
|
|
||||||
// FormatEpochTimeInMillisAsIso8601 depends on the current timezone, so we
|
// FormatEpochTimeInMillisAsIso8601 depends on the current timezone, so we
|
||||||
// have to set up a particular timezone to obtain predictable results.
|
// have to set up a particular timezone to obtain predictable results.
|
||||||
|
Loading…
Reference in New Issue
Block a user